ShivsundarR commented on code in PR #18851:
URL: https://github.com/apache/kafka/pull/18851#discussion_r1952500382
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -630,6 +663,26 @@ public CompletableFuture<Void> acknowledgeOnClose(final
Map<TopicIdPartition, No
return closeFuture;
}
+ /**
+ *
+ * @return True if nodeId is the leader or if leader information is not
present for the topicIdPartition.
+ * Returns false if nodeId is not the leader for the given topicIdPartition
+ */
+ private boolean isNodeLeader(int nodeId, TopicIdPartition
topicIdPartition) {
Review Comment:
Thanks, yeah that sounds good. I have updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
