bbejeck commented on code in PR #18856:
URL: https://github.com/apache/kafka/pull/18856#discussion_r1953533199
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/EndpointToPartitionsManager.java:
##########
@@ -47,11 +46,11 @@ public static
StreamsGroupHeartbeatResponseData.EndpointToPartitions endpointToP
final Map<String, TopicMetadata> groupTopicMetadata =
streamsGroup.partitionMetadata();
Set<Map.Entry<String, Set<Integer>>> taskEntrySet =
streamsGroupMember.assignedActiveTasks().entrySet();
- List<StreamsGroupHeartbeatResponseData.TopicPartition>
topicPartitionList = getTopicPartitions(taskEntrySet, sourceTopics,
repartitionSourceTopics, groupTopicMetadata);
+ List<StreamsGroupHeartbeatResponseData.TopicPartition>
topicPartitionList = getTopicPartitions(taskEntrySet, sourceTopics,
groupTopicMetadata);
Review Comment:
@lucasbru - good question. I'll update the test to be more clear, but it
should be the case that active tasks for both instances get source partitions.
Since there's two sub-topologies with two partitions, each instance gets one of
each.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
