AndrewJSchofield commented on code in PR #18834:
URL: https://github.com/apache/kafka/pull/18834#discussion_r1954321708
##########
clients/src/main/java/org/apache/kafka/common/requests/DescribeShareGroupOffsetsResponse.java:
##########
@@ -18,20 +18,56 @@
package org.apache.kafka.common.requests;
import org.apache.kafka.common.message.DescribeShareGroupOffsetsResponseData;
+import
org.apache.kafka.common.message.DescribeShareGroupOffsetsResponseData.DescribeShareGroupOffsetsResponseGroup;
import org.apache.kafka.common.protocol.ApiKeys;
import org.apache.kafka.common.protocol.ByteBufferAccessor;
import org.apache.kafka.common.protocol.Errors;
import java.nio.ByteBuffer;
+import java.util.ArrayList;
import java.util.HashMap;
+import java.util.List;
import java.util.Map;
public class DescribeShareGroupOffsetsResponse extends AbstractResponse {
private final DescribeShareGroupOffsetsResponseData data;
+ private final Map<String, Throwable> groupLevelErrors = new HashMap<>();
public
DescribeShareGroupOffsetsResponse(DescribeShareGroupOffsetsResponseData data) {
super(ApiKeys.DESCRIBE_SHARE_GROUP_OFFSETS);
this.data = data;
+ for (DescribeShareGroupOffsetsResponseGroup group : data.groups()) {
+ if (group.errorCode() != Errors.NONE.code()) {
+ this.groupLevelErrors.put(group.groupId(),
Errors.forCode(group.errorCode()).exception(group.errorMessage()));
+ }
+ }
+ }
+
+ // Builds a response with the same group-level error for all groups and
empty topics lists for all groups
+ public DescribeShareGroupOffsetsResponse(int throttleTimeMs,
+ List<String> groupIds,
+ Throwable allGroupsException) {
+ super(ApiKeys.DESCRIBE_SHARE_GROUP_OFFSETS);
+ short errorCode = Errors.forException(allGroupsException).code();
+ List<DescribeShareGroupOffsetsResponseGroup> groupList = new
ArrayList<>();
+ groupIds.forEach(groupId -> {
+ groupList.add(new DescribeShareGroupOffsetsResponseGroup()
+ .setGroupId(groupId)
+ .setErrorCode(errorCode)
+ .setErrorMessage(errorCode ==
Errors.UNKNOWN_SERVER_ERROR.code() ? Errors.forCode(errorCode).message() :
allGroupsException.getMessage()));
Review Comment:
This behaviour is as a result of a test which makes sure that the exception
string does not "leak" through into a response. I suppose the idea is that if
you are not in control of the string, you might not want the error message to
appear in the client. In practice, I think this is only helpful for
`UNKNOWN_SERVER_ERROR`, so that's what I did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
