dajac commented on code in PR #18902:
URL: https://github.com/apache/kafka/pull/18902#discussion_r1956396281
##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -95,10 +95,13 @@ public void testFromVersionString() {
assertEquals(IBP_3_9_IV0, MetadataVersion.fromVersionString("3.9"));
assertEquals(IBP_3_9_IV0,
MetadataVersion.fromVersionString("3.9-IV0"));
+ // 4.0-IV3 is the latest production version in the 4.0 line
assertEquals(IBP_4_0_IV0,
MetadataVersion.fromVersionString("4.0-IV0"));
assertEquals(IBP_4_0_IV1,
MetadataVersion.fromVersionString("4.0-IV1"));
assertEquals(IBP_4_0_IV2,
MetadataVersion.fromVersionString("4.0-IV2"));
assertEquals(IBP_4_0_IV3,
MetadataVersion.fromVersionString("4.0-IV3"));
+
+ assertEquals(IBP_4_1_IV0,
MetadataVersion.fromVersionString("4.1-IV0"));
Review Comment:
Do you mean two empty lines before? It does not seem necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
