smjn commented on code in PR #18848:
URL: https://github.com/apache/kafka/pull/18848#discussion_r1956713206
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -6280,6 +6286,48 @@ public void createGroupTombstoneRecords(
group.createGroupTombstoneRecords(records);
}
+ /**
+ * Returns an optional of delete share group request object to be used
with the persister.
Review Comment:
Ok - the empty check actually does not belong here. I will move the check to
the `GroupCoordinatorShard.sharePartitionDeleteRequests`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
