mjsax commented on code in PR #18835:
URL: https://github.com/apache/kafka/pull/18835#discussion_r1956772003
##########
tests/kafkatest/tests/streams/streams_smoke_test.py:
##########
@@ -109,5 +109,7 @@ def test_streams(self, processing_guarantee, crash,
metadata_quorum):
if crash and processing_guarantee == 'at_least_once':
self.driver.node.account.ssh("grep -E
'SUCCESS|PROCESSED-MORE-THAN-GENERATED' %s" % self.driver.STDOUT_FILE,
allow_fail=False)
+ # fail if we find "missing result data" output in the stdout file;
while we can tolerate duplication, we cannot tolerate data loss
+ self.driver.node.account.ssh("[ ! `grep 'missing result data'" %
self.driver.STDOUT_FILE % "` ]", allow_fail=False)
else:
self.driver.node.account.ssh("grep SUCCESS %s" %
self.driver.STDOUT_FILE, allow_fail=False)
Review Comment:
> The issue that led to this PR was that the output contained
PROCESSED-MORE-THAN-GENERATED and FAILURE
I don't have the old log files from my local testing any longer, so cannot
remember exactly, and I believe to remember we might still have gotten
"SUCCESS" (do you still have old logs?)
However `PROCESSED-MORE-THAN-GENERATED` is just a check for the "echo"
output topic anyway, not for any other topic, so even if we read the output
topic, it's more of an check what input we did process. -- For ALOS, we could
read and process an input record more than ones.
> But since the test found PROCESSED-MORE-THAN-GENERATED it decided that the
run was successful although there was a failure.
Yes, but the new log lines and parsing fixes this.
> If we can ensure that under ALOS the test still outputs a SUCCESS in the
output also if it processed some records multiple times, we could simplify this
check.
Well, it does. Outputting `PROCESSED-MORE-THAN-GENERATED ` is independent of
`SUCCESS` vs `FAILURE`.
Overall, it's always a split brain problem between Java and Python code, so
not sure how to improve it with "reasonable" effort... If you insist, I can
spent a few more hour to fix it up, but personally, I don't see a large gain
spending the time. Please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
