TaiJuWu commented on code in PR #18850: URL: https://github.com/apache/kafka/pull/18850#discussion_r1957242661
########## clients/src/main/java/org/apache/kafka/clients/consumer/GroupProtocol.java: ########## @@ -23,7 +23,10 @@ public enum GroupProtocol { CLASSIC("CLASSIC"), /** Consumer group protocol */ - CONSUMER("CONSUMER"); + CONSUMER("CONSUMER"), + + /** Share group protocol */ + SHARE("SHARE"); Review Comment: Hi @AndrewJSchofield , I add config checker to `GroupRebalanceConfig`. Is this change ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org