smjn opened a new pull request, #18922:
URL: https://github.com/apache/kafka/pull/18922

   * The `share.coordinator.state.topic.min.isr` config defined in 
`ShareCoordinatorConfig` was not being used in the `AutoTopicCreationManager`. 
   * The `AutoTopicCreationManager` calls the 
`ShareCoordinatorService.shareGroupStateTopicConfigs` to configs for the topic 
to create.
   * The method `ShareCoordinatorService.shareGroupStateTopicConfigs` was not 
setting the supplied config value for `share.coordinator.state.topic.min.isr` 
to `min.insync.replicas`.
   * In this PR, we remedy the situation by setting the value.
   * A test has been added to `ShareCoordinatorServiceTest` so that this is not 
repeated for any configs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to