frankvicky commented on code in PR #18921:
URL: https://github.com/apache/kafka/pull/18921#discussion_r1958195310


##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -3279,7 +3279,7 @@ private long pollUnattachedAsVoter(UnattachedState state, 
long currentTimeMs) {
             // If shutting down, then remain in this state until either the
             // shutdown completes or an epoch bump forces another state 
transition
             return shutdown.remainingTimeMs();
-        } else if (state.hasElectionTimeoutExpired(currentTimeMs)) {
+        } else if (state.hasFetchTimeoutExpired(currentTimeMs)) {

Review Comment:
   If I understand correctly, we should use fetch timeout instead of election 
timeout when aligning with the follower's transition to the prospective state.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to