AndrewJSchofield commented on code in PR #18929:
URL: https://github.com/apache/kafka/pull/18929#discussion_r1958604469
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3272,7 +3272,36 @@ class KafkaApis(val requestChannel: RequestChannel,
def handleAlterShareGroupOffsetsRequest(request: RequestChannel.Request):
Unit = {
val alterShareGroupOffsetsRequest =
request.body[AlterShareGroupOffsetsRequest]
- requestHelper.sendMaybeThrottle(request,
alterShareGroupOffsetsRequest.getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
+ val groupId = alterShareGroupOffsetsRequest.data.groupId
+ if (!isShareGroupProtocolEnabled) {
+ requestHelper.sendMaybeThrottle(request,
alterShareGroupOffsetsRequest.getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
+ } else if (!authHelper.authorize(request.context, WRITE, GROUP, groupId)) {
Review Comment:
I know this is still in draft but I am making sure all admin operations on
share groups are correctly authorised. This should be READ GROUP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
