showuon commented on code in PR #18004:
URL: https://github.com/apache/kafka/pull/18004#discussion_r1959292369
##########
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##########
@@ -619,27 +638,32 @@ class RemoteIndexCacheTest {
val entry0 = cache.getIndexEntry(metadataList.head)
val entry1 = cache.getIndexEntry(metadataList(1))
- cache.getIndexEntry(metadataList(2))
+ val entry2 = cache.getIndexEntry(metadataList(2))
+ val entries = List(entry0, entry1, entry2)
assertCacheSize(2)
- verifyEntryIsEvicted(metadataList.head, entry0)
+ val (evictedSegmentMetadata, evictedEntry) =
verifyEntryIsEvicted(metadataList, entries, 1)
- // Reduce cache capacity to only store 1 entry
+ // Reduce cache capacity to only store 1 entry and check two entries are
marked as deleted.
Review Comment:
nit: comment needs to be updated.
##########
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##########
@@ -619,27 +638,32 @@ class RemoteIndexCacheTest {
val entry0 = cache.getIndexEntry(metadataList.head)
val entry1 = cache.getIndexEntry(metadataList(1))
- cache.getIndexEntry(metadataList(2))
+ val entry2 = cache.getIndexEntry(metadataList(2))
+ val entries = List(entry0, entry1, entry2)
assertCacheSize(2)
- verifyEntryIsEvicted(metadataList.head, entry0)
+ val (evictedSegmentMetadata, evictedEntry) =
verifyEntryIsEvicted(metadataList, entries, 1)
- // Reduce cache capacity to only store 1 entry
+ // Reduce cache capacity to only store 1 entry and check two entries are
marked as deleted.
cache.resizeCacheSize(1 * estimateEntryBytesSize)
assertCacheSize(1)
- verifyEntryIsEvicted(metadataList(1), entry1)
+ // After resize, we need to check an entry is deleted from cache and exist
segmentMetadata
+ val entryInCache = entries.filterNot(evictedEntry.contains(_))
+ val existSegmentMetadata =
metadataList.filterNot(evictedSegmentMetadata.contains(_))
Review Comment:
nit: maybe rename `existSegmentMetadata` to `updatedSegmentMetadata`?
##########
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##########
@@ -619,27 +638,32 @@ class RemoteIndexCacheTest {
val entry0 = cache.getIndexEntry(metadataList.head)
val entry1 = cache.getIndexEntry(metadataList(1))
- cache.getIndexEntry(metadataList(2))
+ val entry2 = cache.getIndexEntry(metadataList(2))
+ val entries = List(entry0, entry1, entry2)
assertCacheSize(2)
- verifyEntryIsEvicted(metadataList.head, entry0)
+ val (evictedSegmentMetadata, evictedEntry) =
verifyEntryIsEvicted(metadataList, entries, 1)
- // Reduce cache capacity to only store 1 entry
+ // Reduce cache capacity to only store 1 entry and check two entries are
marked as deleted.
cache.resizeCacheSize(1 * estimateEntryBytesSize)
assertCacheSize(1)
- verifyEntryIsEvicted(metadataList(1), entry1)
+ // After resize, we need to check an entry is deleted from cache and exist
segmentMetadata
Review Comment:
nit: is deleted from cache and [the] exist[ing] segmentMetadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
