apoorvmittal10 commented on code in PR #17011:
URL: https://github.com/apache/kafka/pull/17011#discussion_r1960653197
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java:
##########
@@ -150,6 +159,37 @@ public GroupCoordinatorMetrics(MetricsRegistry registry,
Metrics metrics) {
Collections.singletonMap(CONSUMER_GROUP_COUNT_STATE_TAG,
ConsumerGroupState.DEAD.toString())
);
+ shareGroupCountMetricName = metrics.metricName(
+ SHARE_GROUP_COUNT_METRIC_NAME,
+ METRICS_GROUP,
+ "The total number of share groups.",
+ Collections.singletonMap(SHARE_GROUP_PROTOCOL_TAG,
Group.GroupType.SHARE.toString())
+ );
+
+ shareGroupCountEmptyMetricName = metrics.metricName(
+ SHARE_GROUP_COUNT_METRIC_NAME,
+ METRICS_GROUP,
+ "The number of share groups in empty state.",
+ SHARE_GROUP_PROTOCOL_TAG, Group.GroupType.SHARE.toString(),
Review Comment:
If I remember correctly, then the metric was more aligned with other
`group-count` metric where `protocol` is added as a tag. But looking at it
again, I think you are right we should align them similarly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
