ahuang98 commented on PR #18600: URL: https://github.com/apache/kafka/pull/18600#issuecomment-2669365217
> the easiest way is to test all protocols since the key difference between these protocols is support re-config or not. WDYT? I don't disagree it would be easy/fine to test all protocols in KafkaRaftClientTest - just to motivate why it may be excessive though - as you said we're basically testing w/o reconfig and w/ reconfig. Since each protocol is cumulative (e.g. `KIP_853_PROTOCOL` necessarily includes `KIP_595_PROTOCOL`, `KIP_996_PROTOCOL` includes `KIP_853_PROTOCOL` and `KIP_595_PROTOCOL`), testing a version before KIP_853 and any one version after KIP_853 should be sufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
