cmccabe commented on PR #18954: URL: https://github.com/apache/kafka/pull/18954#issuecomment-2669387382
@dajac I commented that this is probably not the right approach. We probably need some kind of custom logic for what you are trying to do since the framework treats the associated MV of the enum as both the *minimum to enable* and the *first version where the feature defaults to on*. It should be straightforward to add your custom default to `Formatter.java` and leave the `EligibleLeaderReplicasVersion.java` enum alone. You should also have a test of this working with 4.0-IV1 (not 4.1) to make sure this all works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
