[ 
https://issues.apache.org/jira/browse/KAFKA-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729978#comment-16729978
 ] 

ASF GitHub Bot commented on KAFKA-7773:
---------------------------------------

hachikuji commented on pull request #6070: KAFKA-7773; Add end to end system 
test relying on verifiable consumer
URL: https://github.com/apache/kafka/pull/6070
 
 
   This patch creates an `EndToEndTest` base class which relies on the 
verifiable consumer. This will ultimately replace `PlaintextConsumerTest` which 
depends on the console consumer. The advantage is that we can the verifiable 
consumer exposes more information that can be used for validation. It also 
allows for a nicer shutdown pattern. Rather than relying on the console 
consumer idle timeout, which requires a minimum wait time, we can halt 
consumption after we have reached the last acked offsets. This should be more 
reliable and faster. The downside is that the verifiable consumer only works 
with the new consumer, so we cannot yet convert the upgrade tests.  In this 
patch, I've converted only the replication tests and a flaky security test to 
use `EndToEndTest`. 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Use verifiable consumer in system tests to avoid reliance on console consumer 
> idle timeout
> ------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-7773
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7773
>             Project: Kafka
>          Issue Type: Improvement
>          Components: system tests
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>            Priority: Major
>
> We have a few system tests which use `ProduceConsumeValidateTest`, which 
> relies on the console consumer's idle timeout for shutdown. We should convert 
> these systems tests to use the verifiable consumer instead so that we can 
> control shutdown more finely and we have more validation options. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to