junrao commented on code in PR #18997:
URL: https://github.com/apache/kafka/pull/18997#discussion_r1966296852


##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -753,6 +753,10 @@ public void testBalancePartitionLeaders() throws Throwable 
{
             QuorumController active = controlEnv.activeController();
             Map<Integer, Long> brokerEpochs = new HashMap<>();
 
+            TestUtils.waitForCondition(() ->
+                    
active.featureControl().finalizedFeatures(Long.MAX_VALUE).featureMap().get(MetadataVersion.FEATURE_NAME)
 == SIMPLE_BOOTSTRAP.metadataVersion().featureLevel(),

Review Comment:
   Since we need to wait for QuorumController to fully bootstrap before doing 
the remaining test, it seems that we should just call 
`controlEnv.activeController(true)` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to