Yunyung commented on code in PR #18918:
URL: https://github.com/apache/kafka/pull/18918#discussion_r1966680545
##########
build.gradle:
##########
@@ -2485,7 +2485,9 @@ project(':tools') {
from (configurations.runtimeClasspath) {
exclude('kafka-clients*')
}
- from (configurations.releaseOnly)
+ from (configurations.releaseOnly) {
+ exclude('log4j-slf4j-impl-*.jar')
Review Comment:
As far as I know, `dependant-lib` is only included in `kafka-run-class.sh`
For `core/build/dependant-lib-${SCALA_VERSION}`
https://github.com/apache/kafka/blob/trunk/bin/kafka-run-class.sh#L64-L69
```
if [ -z "$UPGRADE_KAFKA_STREAMS_TEST_VERSION" ]; then
for dir in "$base_dir"/core/build/dependant-libs-${SCALA_VERSION}*;
do
CLASSPATH="$CLASSPATH:$dir/*"
done
fi
```
For `tools/build/dependant-lib-${SCALA_VERSION} `
https://github.com/apache/kafka/blob/trunk/bin/kafka-run-class.sh#L150-L153
```
for dir in "$base_dir"/tools/build/dependant-libs-${SCALA_VERSION}*;
do
CLASSPATH="$CLASSPATH:$dir/*"
done
```
If we prefer this kind of change, including
tools/build/dependant-lib-${SCALA_VERSION} instead might be a better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
