mumrah commented on PR #18449:
URL: https://github.com/apache/kafka/pull/18449#issuecomment-2678911889
> Alternatively, to maximize cache usage, could we automatically run the PR
against the latest cached commit as a base?
This would require doing something similar to the merge ref, but for the
latest cache SHA (instead of trunk HEAD). I think it's probably achievable, but
maybe a bit tricky to do correctly. I imagine there are probably cases where
the PR can't be merged into the cache SHA. For example, maybe the PR has
already merged in trunk beyond the cached SHA and made some additional commits.
It still might be worth exploring though.
For now, I think this approach is easy to understand ("build the code in the
PR branch"), should give us some caching boost, and hopefully causes few
surprises.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
