Re: [PR] HOTFIX: remove PageView example to support Java11 for :streams:examples module [kafka]

[via GitHub]

gharris1727 commented on code in PR #19052:
URL: https://github.com/apache/kafka/pull/19052#discussion_r1974314924


##########
docs/streams/developer-guide/datatypes.html:
##########
@@ -156,11 +156,9 @@ <h3>Primitive and basic types<a class="headerlink" 
href="#primitive-and-basic-ty
       </div>
       <div class="section" id="json">
         <h3>JSON<a class="headerlink" href="#json" title="Permalink to this 
headline"></a></h3>
-        <p>The Kafka Streams code examples also include a basic serde 
implementation for JSON:</p>
-        <ul class="simple">
-          <li><a class="reference external" 
href="https://github.com/apache/kafka/blob/{{dotVersion}}/streams/examples/src/main/java/org/apache/kafka/streams/examples/pageview/PageViewTypedDemo.java#L83";>PageViewTypedDemo</a></li>
-        </ul>
-        <p>As shown in the example, you can use JSONSerdes inner classes <code 
class="docutils literal"><span 
class="pre">Serdes.serdeFrom(&lt;serializerInstance&gt;, 
&lt;deserializerInstance&gt;)</span></code> to construct JSON compatible 
serializers and deserializers.
+        <p>You can use <code>JsonSerializer</code> and 
<code>JsonDeerializer</code> from Kafka Connect to construct JSON compatible 
serializers and deserializers

Review Comment:
   ```suggestion
           <p>You can use <code>JsonSerializer</code> and 
<code>JsonDeserializer</code> from Kafka Connect to construct JSON compatible 
serializers and deserializers
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org