mjsax commented on code in PR #18963:
URL: https://github.com/apache/kafka/pull/18963#discussion_r1976505917
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java:
##########
@@ -397,7 +397,7 @@ public void testStressfulSituation() throws Exception {
List<ProducerBatch> batches = accum.drain(metadataCache, nodes, 5
* 1024, 0).get(node1.id());
if (batches != null) {
for (ProducerBatch batch : batches) {
- for (Record record : batch.records().records())
+ for (@SuppressWarnings("UnusedLocalVariable") Record
ignored : batch.records().records())
read++;
Review Comment:
Why not use `ProducerBatch#recordCount` and avoid the loop entirely?
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -621,6 +621,7 @@ protected void assertInitializedMetric(WorkerConnector
workerConnector, String e
String type = metrics.currentMetricValueAsString(metricGroup,
"connector-type");
String clazz = metrics.currentMetricValueAsString(metricGroup,
"connector-class");
String version = metrics.currentMetricValueAsString(metricGroup,
"connector-version");
+ assertEquals("unassigned", status);
Review Comment:
Aha! Already found one test gap. Loving it.
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -885,7 +885,8 @@ public Set<StreamTask> drainRestoredActiveTasks(final
Duration timeout) {
restoredActiveTasksLock.lock();
try {
while (restoredActiveTasks.isEmpty() && now <= deadline) {
- final boolean elapsed =
restoredActiveTasksCondition.await(deadline - now, TimeUnit.MILLISECONDS);
+ @SuppressWarnings("UnusedLocalVariable")
+ final boolean ignored =
restoredActiveTasksCondition.await(deadline - now, TimeUnit.MILLISECONDS);
Review Comment:
Should we add a comment why it is ok to ignore the result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
