chia7712 commented on code in PR #19070:
URL: https://github.com/apache/kafka/pull/19070#discussion_r1976564129
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -339,6 +339,8 @@ private ApiError validateAlterConfig(
return DISALLOWED_CLUSTER_MIN_ISR_REMOVAL_ERROR;
} else if (configRecord.value() == null) {
allConfigs.remove(configRecord.name());
+ } else if (configRecord.value().length() > Short.MAX_VALUE) {
+ return DISALLOWED_CONFIG_VALUE_SIZE_ERROR;
Review Comment:
I meant the comment should explain why to throw specific exception ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
