Re: [PR] KAFKA-18876: 4.0 documentation improvement [kafka]

[via GitHub]

mingdaoy commented on code in PR #19065:
URL: https://github.com/apache/kafka/pull/19065#discussion_r1976674845


##########
docs/ops.html:
##########
@@ -3827,22 +3827,22 @@ <h4 class="anchor-heading"><a id="kraft_storage" 
class="anchor-link"></a><a href
   <h5 class="anchor-heading"><a id="kraft_storage_standalone" 
class="anchor-link"></a><a href="#kraft_storage_standalone">Bootstrap a 
Standalone Controller</a></h5>
   The recommended method for creating a new KRaft controller cluster is to 
bootstrap it with one voter and dynamically <a href="#kraft_reconfig_add">add 
the rest of the controllers</a>. Bootstrapping the first controller can be done 
with the following CLI command:
 
-  <pre><code class="language-bash">$ bin/kafka-storage.sh format --cluster-id 
&lt;cluster-id&gt; --standalone --config controller.properties</code></pre>
+  <pre><code class="language-bash">$ bin/kafka-storage.sh format --cluster-id 
&lt;cluster-id&gt; --standalone --config 
config/controller.properties</code></pre>

Review Comment:
   
![image](https://github.com/user-attachments/assets/2a555999-224f-419a-891f-2332f00f77c0)
   



##########
docs/ops.html:
##########
@@ -3851,7 +3851,7 @@ <h5 class="anchor-heading"><a id="kraft_storage_voters" 
class="anchor-link"></a>
   <h5 class="anchor-heading"><a id="kraft_storage_observers" 
class="anchor-link"></a><a href="#kraft_storage_observers">Formatting Brokers 
and New Controllers</a></h5>
   When provisioning new broker and controller nodes that we want to add to an 
existing Kafka cluster, use the <code>kafka-storage.sh format</code> command 
with the --no-initial-controllers flag.
 
-  <pre><code class="language-bash">$ bin/kafka-storage.sh format --cluster-id 
&lt;cluster-id&gt; --config server.properties 
--no-initial-controllers</code></pre>
+  <pre><code class="language-bash">$ bin/kafka-storage.sh format --cluster-id 
&lt;cluster-id&gt; --config config/server.properties 
--no-initial-controllers</code></pre>

Review Comment:
   
![image](https://github.com/user-attachments/assets/4ed8779e-e684-4fa1-9217-5d8403770e1c)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org