chia7712 commented on code in PR #18926:
URL: https://github.com/apache/kafka/pull/18926#discussion_r1976738391


##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##########
@@ -359,7 +356,10 @@ public void 
testInitializeAsResignedLeaderFromStateStore(boolean withKip853Rpc)
         assertEquals(0L, context.log.endOffset().offset());
         context.assertElectedLeader(epoch, localId);
         context.client.poll();
-        assertThrows(NotLeaderException.class, () -> 
context.client.prepareAppend(epoch, Arrays.asList("a", "b")));
+        // Only one method invocation is expected when testing runtime 
exceptions

Review Comment:
   Pardon me, I don't catch the point of this change. Is it a refactor about 
code style?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to