mumrah commented on code in PR #19031: URL: https://github.com/apache/kafka/pull/19031#discussion_r1978373193
########## .github/actions/run-gradle/action.yml: ########## @@ -86,7 +86,10 @@ runs: run: | set +e ./.github/scripts/thread-dump.sh & - timeout ${TIMEOUT_MINUTES}m ./gradlew --build-cache --continue --no-scan \ + mkdir -p heap-dumps + HEAP_DUMP_DIR=$(readlink -f heap-dumps) + timeout ${TIMEOUT_MINUTES}m ./gradlew --continue --no-scan \ + -Dorg.gradle.jvmargs="-Xmx4g -Xss4m -XX:+UseParallelGC -XX:+UseGCOverheadLimit -XX:+ExitOnOutOfMemoryError -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=$HEAP_DUMP_DIR" \ Review Comment: We need to pass the heap dump path directly to Gradle as well as to JUnit (inside build.gradle). That's why we have this apparent duplication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org