chia7712 commented on code in PR #19087:
URL: https://github.com/apache/kafka/pull/19087#discussion_r1979811935


##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -689,6 +692,9 @@ class KafkaConfig private(doLog: Boolean, val props: 
util.Map[_, _])
       if (controllerListenerNames.size > 1) {
         warn(s"${KRaftConfigs.CONTROLLER_LISTENER_NAMES_CONFIG} has multiple 
entries; only the first will be used since 
${KRaftConfigs.PROCESS_ROLES_CONFIG}=broker: ${controllerListenerNames.asJava}")
       }
+      // warn if create.topic.policy.class.name or 
alter.config.policy.class.name is defined in the broker role
+      warnIfConfigDefinedInWrongRole(ProcessRole.ControllerRole, 
ServerLogConfigs.CREATE_TOPIC_POLICY_CLASS_NAME_CONFIG)

Review Comment:
   we should log the warnings ONLY IF the policy is defined on the broker node.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to