FrankYang0529 commented on PR #18685: URL: https://github.com/apache/kafka/pull/18685#issuecomment-2703450996
@jsancio @MahsaSeifikar @ijuma Thanks for review. I put this PR in WIP cause of two reasons: 1. With this fix, I observed that feature epoch keeps increasing. In trunk branch, if a cluster is stable, its feature epoch doesn't increase. 2. Dynamic voter in test framework doesn't match real case. In `KafkaClusterTestKit` [0], it uses `BootstrapMetadata#featureLevel` [1] to check `kraft.version`. It goes through all `FeatureLevelRecord` and gets a value. In the real cluster, the `kraft.version` is stored in `KRaftVersionRecord`. I already addressed this in the second commit. I think `ReconfigurableQuorumIntegrationTest#testCreateAndDestroyReconfigurableCluster` can be used as the test case. [0] https://github.com/apache/kafka/blob/041d8019d6f73a31a591ffba22b0fdfc3e56a9c5/test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java#L445-L457 [1] https://github.com/apache/kafka/blob/041d8019d6f73a31a591ffba22b0fdfc3e56a9c5/metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java#L128-L138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
