Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]

[via GitHub]

dengziming commented on PR #19109:
URL: https://github.com/apache/kafka/pull/19109#issuecomment-2705871265

   Hello @ijuma @chia7712 . 
   The existing test cases are sufficient for spotting this bug, they didn't 
fail because we didn't bump the version in the previous PR.
   If we bump the version to 1 adding a new field, then several test cases 
would fail on `java.nio.BufferUnderflowException` because it treat 
version-0-buffer as version-1-buffer but unable to read new data.
   
   I also validated it locally:
   
![image](https://github.com/user-attachments/assets/acf76524-dacc-4130-8a5e-5fd5864f4be4)
   
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org