adixitconfluent commented on code in PR #19148:
URL: https://github.com/apache/kafka/pull/19148#discussion_r1985037801
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3139,15 +3135,15 @@ class KafkaApis(val requestChannel: RequestChannel,
val erroneous = mutable.Map.empty[TopicIdPartition,
ShareFetchResponseData.PartitionData]
erroneousAndValidPartitionData.erroneous.forEach { (topicIdPartition,
partitionData) => erroneous.put(topicIdPartition, partitionData) }
- val interestedWithMaxBytes = new util.LinkedHashMap[TopicIdPartition,
Integer]
+ val interestedTopicPartitions = new util.LinkedHashSet[TopicIdPartition]
Review Comment:
my bad, I saw this
[line](https://github.com/apache/kafka/pull/19148/files#diff-cc056b4960ededba37a438b1454f0f3c5ff5e8ad5e6d2ec9a08e813ca056ffebR3000)
and a couple of lines in tests because of which I though `Set` is required
here, should we use `List` then with an internal implementation of `ArrayList`
then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
