chia7712 commented on code in PR #19149:
URL: https://github.com/apache/kafka/pull/19149#discussion_r1985580616
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/TransactionIndexTest.java:
##########
@@ -272,7 +273,7 @@ void testAppendAndCollectAfterClose() throws IOException {
}
@Test
- void testAppendAndCollectAfterInterrupted() throws Exception {
+ public void testAppendAndCollectAfterInterrupted() throws Exception {
Review Comment:
this is unnecessary.
```
chia7712@chia7712-ubuntu:~/project/kafka$ ./gradlew cleanTest storage:test
--tests TransactionIndexTest.testAppendAndCollectAfterInterrupted
> Configure project :
Starting build with version 4.1.0-SNAPSHOT (commit id 6940bef6) using Gradle
8.10.2, Java 21 and Scala 2.13.15
Build properties: ignoreFailures=false, maxParallelForks=24,
maxScalacThreads=8, maxTestRetries=0
> Task :group-coordinator:compileTestJava
Note:
/home/chia7712/project/kafka/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java
uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
> Task :storage:test
Gradle Test Run :storage:test > Gradle Test Executor 45 >
TransactionIndexTest > testAppendAndCollectAfterInterrupted() PASSED
BUILD SUCCESSFUL in 27s
146 actionable tasks: 20 executed, 126 up-to-date
```
##########
storage/src/test/java/org/apache/kafka/storage/internals/log/TransactionIndexTest.java:
##########
@@ -245,7 +246,7 @@ public void testDoNotCreateFileUntilNeeded() throws
IOException {
}
@Test
- void testAppendAndCollectAfterClose() throws IOException {
+ public void testAppendAndCollectAfterClose() throws IOException {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
