ashrivastava88 commented on code in PR #18074:
URL: https://github.com/apache/kafka/pull/18074#discussion_r1986112509
##########
connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java:
##########
@@ -466,16 +466,16 @@ protected boolean readPartition(TopicPartition
topicPartition) {
return true;
}
- private void poll(long timeoutMs) {
+ private void poll() {
try {
- ConsumerRecords<K, V> records =
consumer.poll(Duration.ofMillis(timeoutMs));
+ ConsumerRecords<K, V> records =
consumer.poll(Duration.ofMillis(Integer.MAX_VALUE));
Review Comment:
the timeout here is getting set to Integer.MAX_VALUE,, so if we have any
failure at consumer fetch.
the consumer will keep on retrying till this timeout is reached.
We have had a case at confluent,, where one of our customer shared logs,,
and it is filled with the consumer fetch,, retrying ,, and every subsequent
timeout is decresing,, from this Integer.MAX_VALUE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
