chia7712 commented on PR #19062: URL: https://github.com/apache/kafka/pull/19062#issuecomment-2709553640
> For the classes without hashCode/equals, we are verifying that it's ok to change the implementation of hashCode and equals? Regarding `LogAppendInfo`, `LogFetchInfo`, and `SnapshotPath`: Currently, their `hashCode/equals` methods are not utilized in production code. A potential concern is `LogFetchInfo`'s mutable `Records` field, which is generally discouraged. @ijuma, what are your thoughts? Should we revert the LogFetchInfo changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
