mannoopj commented on code in PR #19165:
URL: https://github.com/apache/kafka/pull/19165#discussion_r1990192958
##########
generator/src/main/java/org/apache/kafka/message/checker/MetadataSchemaCheckerTool.java:
##########
@@ -85,31 +82,24 @@ public static void run(
break;
}
case "verify-evolution": {
- String path1 = namespace.getString("path1");
- String path2 = namespace.getString("path2");
+ String path = namespace.getString("path");
+ String parent = namespace.getString("parent_path");
EvolutionVerifier verifier = new EvolutionVerifier(
- CheckerUtils.readMessageSpecFromFile(path1),
- CheckerUtils.readMessageSpecFromFile(path2));
+ CheckerUtils.readMessageSpecFromFile(path),
+ CheckerUtils.readMessageSpecFromFile(parent));
Review Comment:
From the original code `path1` is the original schema and `path2` is the
updated version. From the changes made to the subparser `path1` has become
`path` and `path2` has become `parent_path`. Assuming parent is meant to be the
original that switch hasn't been made over here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
