m1a2st commented on code in PR #18861:
URL: https://github.com/apache/kafka/pull/18861#discussion_r1994461137
##########
storage/src/test/java/org/apache/kafka/tiered/storage/actions/ConsumeAction.java:
##########
@@ -171,20 +171,48 @@ public void doExecute(TieredStorageTestContext context)
throws InterruptedExcept
expectedCountAndOp = new
RemoteFetchCount.FetchCountAndOp(-1, RemoteFetchCount.OperationType.EQUALS_TO);
}
- String message = String.format("Number of %s requests from broker
%d to the tier storage does not match the expected value for topic-partition
%s",
- eventType, remoteFetchSpec.getSourceBrokerId(),
remoteFetchSpec.getTopicPartition());
- if (expectedCountAndOp.getCount() != -1) {
- if (expectedCountAndOp.getOperationType() ==
RemoteFetchCount.OperationType.EQUALS_TO) {
- assertEquals(expectedCountAndOp.getCount(),
eventsInScope.size(), message);
- } else if (expectedCountAndOp.getOperationType() ==
RemoteFetchCount.OperationType.LESS_THAN_OR_EQUALS_TO) {
- assertTrue(eventsInScope.size() <=
expectedCountAndOp.getCount(), message);
+ RemoteFetchCount.OperationType exceptedOperationType =
expectedCountAndOp.getOperationType();
Review Comment:
I think we should keep the flaky annotation for now and observe for a while.
Once we confirm that no errors occur in the CI, we can proceed with its
removal. WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
