[ 
https://issues.apache.org/jira/browse/KAFKA-18984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935502#comment-17935502
 ] 

Chia-Ping Tsai commented on KAFKA-18984:
----------------------------------------

[~schofielaj] Thank you for the suggestion, and I apologize for not noticing 
earlier that kafka-client-metrics.sh is capable of resetting specific 
configurations.

{code:java}
// reset `metrics`
./bin/kafka-client-metrics.sh  --alter --bootstrap-server=192.168.1.144:20001 
--name chia --metrics=
{code}

However, this method contains a defect wherein it fails to function correctly 
for `interval` due to a conversion error.

{code:java}
[2025-03-14 20:07:00,623] ERROR joptsimple.OptionArgumentConversionException: 
Cannot parse argument '' of option interval
        at joptsimple.AbstractOptionSpec.convertWith(AbstractOptionSpec.java:92)
        at 
joptsimple.ArgumentAcceptingOptionSpec.convert(ArgumentAcceptingOptionSpec.java:277)
        at joptsimple.OptionSet.valuesOf(OptionSet.java:223)
        at joptsimple.OptionSet.valueOf(OptionSet.java:172)
        at 
org.apache.kafka.tools.ClientMetricsCommand$ClientMetricsCommandOptions.valueAsOption(ClientMetricsCommand.java:287)
        at 
org.apache.kafka.tools.ClientMetricsCommand$ClientMetricsCommandOptions.valueAsOption(ClientMetricsCommand.java:278)
        at 
org.apache.kafka.tools.ClientMetricsCommand$ClientMetricsCommandOptions.interval(ClientMetricsCommand.java:338)
        at 
org.apache.kafka.tools.ClientMetricsCommand$ClientMetricsService.alterClientMetrics(ClientMetricsCommand.java:123)
        at 
org.apache.kafka.tools.ClientMetricsCommand.execute(ClientMetricsCommand.java:83)
        at 
org.apache.kafka.tools.ClientMetricsCommand.mainNoExit(ClientMetricsCommand.java:65)
        at 
org.apache.kafka.tools.ClientMetricsCommand.main(ClientMetricsCommand.java:60)
Caused by: joptsimple.internal.ReflectionException: 
java.lang.NumberFormatException: For input string: ""
        at 
joptsimple.internal.Reflection.reflectionException(Reflection.java:136)
        at joptsimple.internal.Reflection.invoke(Reflection.java:118)
        at 
joptsimple.internal.MethodInvokingValueConverter.convert(MethodInvokingValueConverter.java:48)
        at joptsimple.internal.Reflection.convertWith(Reflection.java:124)
        at joptsimple.AbstractOptionSpec.convertWith(AbstractOptionSpec.java:90)
        ... 10 more
Caused by: java.lang.NumberFormatException: For input string: ""
        at 
java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
        at java.base/java.lang.Integer.parseInt(Integer.java:672)
        at java.base/java.lang.Integer.valueOf(Integer.java:989)
        at 
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at joptsimple.internal.Reflection.invoke(Reflection.java:116)
        ... 13 more
 (org.apache.kafka.tools.ClientMetricsCommand)

{code}

I will change the title to "failed to reset interval.ms by using 
kafka-client-metrics.sh".


> Support to delete specific config by kafka-client-metrics.sh
> ------------------------------------------------------------
>
>                 Key: KAFKA-18984
>                 URL: https://issues.apache.org/jira/browse/KAFKA-18984
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Major
>
> the delete op defined by 
> [KIP-714|https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability#KIP714:Clientmetricsandobservability-Deleteaclientmetricsconfigurationresource]
>  is shown below. 
> {code:java}
> $ kafka-client-metrics.sh --bootstrap-server $BROKERS --delete --name 
> MYMETRICS
>  
> $ kafka-configs.sh --bootstrap-server $BROKERS --alter --entity-type 
> client-metrics --entity-name MYMETRICS \
>   --delete-config metrics,interval.ms,match
> {code}
> That means `kafka-client-metrics.sh` can NOT remove specific config from the 
> client metrics. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to