snehashisp commented on code in PR #17988:
URL: https://github.com/apache/kafka/pull/17988#discussion_r1996284020
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/ConnectorStateInfo.java:
##########
@@ -87,14 +90,26 @@ public String workerId() {
public String trace() {
return trace;
}
+
+ @JsonProperty
+ @JsonInclude(JsonInclude.Include.NON_EMPTY)
Review Comment:
Not so much as misleading users, rather it might cause them to wonder why
some plugins don't show any information on what version is installed. Say if
they have a bunch of legacy plugins that don't properly set a version. Of
course, if they look at the code they can make an educated guess and figure out
that they don't implement Versioned and likewise, but it might be good to show
null/undefined to make it more readily apparent. Either way is fine by me and
we can mention the behavior we choose in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
