mumrah commented on code in PR #19144:
URL: https://github.com/apache/kafka/pull/19144#discussion_r1987340954
##########
build.gradle:
##########
@@ -1531,15 +1531,15 @@ project(':test-common:test-common-runtime') {
}
dependencies {
- implementation project(':test-common:test-common-internal-api')
- implementation project(':clients')
- implementation project(':core')
- implementation project(':group-coordinator')
- implementation project(':metadata')
- implementation project(':raft')
- implementation project(':server')
- implementation project(':server-common')
- implementation project(':storage')
+ api project(':core')
Review Comment:
We do need some of these as `api`. For example, ClusterInstance#brokers
returns BrokerServer which is part of `:core`, so we need to declare that as an
api dependency.
I'll go through and see if we can keep some of these as `implementation`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
