chia7712 commented on code in PR #19071:
URL: https://github.com/apache/kafka/pull/19071#discussion_r1997227330
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java:
##########
@@ -391,24 +386,20 @@ public void testStateStore() {
public void
shouldNotEnableSendingOldValuesIfNotMaterializedAlreadyAndNotForcedToMaterialize()
{
final StreamsBuilder builder = new StreamsBuilder();
- final KTableImpl<String, String, String> table =
- (KTableImpl<String, String, String>) builder.table("topic1",
consumed);
-
+ final var table = assertInstanceOf(KTableImpl.class,
builder.table("topic1", consumed));
table.enableSendingOldValues(false);
- assertThat(table.sendingOldValueEnabled(), is(false));
+ assertFalse(table.sendingOldValueEnabled());
}
@Test
public void
shouldEnableSendingOldValuesIfNotMaterializedAlreadyButForcedToMaterialize() {
final StreamsBuilder builder = new StreamsBuilder();
- final KTableImpl<String, String, String> table =
- (KTableImpl<String, String, String>) builder.table("topic1",
consumed);
-
+ final var table = assertInstanceOf(KTableImpl.class,
builder.table("topic1", consumed));
table.enableSendingOldValues(true);
- assertThat(table.sendingOldValueEnabled(), is(true));
+ assertTrue(table.sendingOldValueEnabled());
Review Comment:
could you please revert those unrelated change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
