chia7712 commented on code in PR #18463:
URL: https://github.com/apache/kafka/pull/18463#discussion_r1998752540
##########
core/src/test/java/kafka/server/BootstrapControllersIntegrationTest.java:
##########
@@ -342,4 +343,22 @@ private void testAcls(ClusterInstance clusterInstance,
boolean usingBootstrapCon
assertEquals(aclBinding, deletedAclBindings.iterator().next());
}
}
+
+ @ClusterTest(
+ brokers = 2,
+ serverProperties = {
+ @ClusterConfigProperty(key =
TopicConfig.MIN_IN_SYNC_REPLICAS_CONFIG, value = "2")
+ }
+ )
+ public void testDescribeConfigs(ClusterInstance clusterInstance) throws
Exception {
+ try (Admin admin = Admin.create(adminConfig(clusterInstance, true))) {
+ ConfigResource resource = new ConfigResource(BROKER, "");
+ Map<ConfigResource, Config> resourceToConfig =
admin.describeConfigs(List.of(resource)).all().get();
+ Config config = resourceToConfig.get(resource);
+ assertNotNull(config);
+ ConfigEntry configEntry =
config.get(TopicConfig.MIN_IN_SYNC_REPLICAS_CONFIG);
Review Comment:
Could you please verify the `source()` too?
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/StaticBrokerConfigTest.java:
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.admin;
+
+
+import org.apache.kafka.common.config.ConfigResource;
+import org.apache.kafka.common.config.TopicConfig;
+import org.apache.kafka.common.test.ClusterInstance;
+import org.apache.kafka.common.test.api.ClusterConfigProperty;
+import org.apache.kafka.common.test.api.ClusterTest;
+import org.apache.kafka.common.test.api.Type;
+import org.apache.kafka.common.test.junit.ClusterTestExtensions;
+import org.apache.kafka.coordinator.group.GroupCoordinatorConfig;
+
+import org.junit.jupiter.api.extension.ExtendWith;
+
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ExecutionException;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+
+@ExtendWith(value = ClusterTestExtensions.class)
+public class StaticBrokerConfigTest {
+ private static final String TOPIC = "topic";
+ private static final String CUSTOM_VALUE = "1048576";
+
+ /**
+ * synonyms of `segment.bytes`
+ */
+ private static final String LOG_SEGMENT_BYTES = "log.segment.bytes";
+
+ @ClusterTest(types = {Type.KRAFT},
+ serverProperties = {
+ @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
+ @ClusterConfigProperty(id = 3000, key = LOG_SEGMENT_BYTES, value =
CUSTOM_VALUE)
+ })
+ public void
testTopicConfigsGetImpactedIfStaticConfigsAddToController(ClusterInstance
cluster)
+ throws ExecutionException, InterruptedException {
+ try (
+ Admin admin = cluster.admin();
+ Admin adminUsingBootstrapController = cluster.admin(Map.of(), true)
+ ) {
+ String value = admin.createTopics(List.of(new NewTopic(TOPIC, 1,
(short) 1)))
+
.config(TOPIC).get().get(TopicConfig.SEGMENT_BYTES_CONFIG).value();
+ assertEquals(CUSTOM_VALUE, value, "Config value should be custom
value since controller have related static config");
+
+ ConfigResource brokerResource = new
ConfigResource(ConfigResource.Type.BROKER, "0");
+ String valueFromBroker =
admin.describeConfigs(List.of(brokerResource))
+
.all().get().get(brokerResource).get(LOG_SEGMENT_BYTES).value();
+ assertNotEquals(CUSTOM_VALUE,
+ valueFromBroker,
+ "Config value should not be custom value since broker don't
have related static config");
+
+ ConfigResource controllerResource = new
ConfigResource(ConfigResource.Type.BROKER, "3000");
+ String valueFromController =
adminUsingBootstrapController.describeConfigs(List.of(controllerResource))
+
.all().get().get(controllerResource).get(LOG_SEGMENT_BYTES).value();
+ assertEquals(CUSTOM_VALUE,
+ valueFromController,
+ "Config value should be custom value since controller have
related static config");
Review Comment:
`have` -> `has`
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/StaticBrokerConfigTest.java:
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.admin;
+
+
+import org.apache.kafka.common.config.ConfigResource;
+import org.apache.kafka.common.config.TopicConfig;
+import org.apache.kafka.common.test.ClusterInstance;
+import org.apache.kafka.common.test.api.ClusterConfigProperty;
+import org.apache.kafka.common.test.api.ClusterTest;
+import org.apache.kafka.common.test.api.Type;
+import org.apache.kafka.common.test.junit.ClusterTestExtensions;
+import org.apache.kafka.coordinator.group.GroupCoordinatorConfig;
+
+import org.junit.jupiter.api.extension.ExtendWith;
+
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ExecutionException;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+
+@ExtendWith(value = ClusterTestExtensions.class)
+public class StaticBrokerConfigTest {
+ private static final String TOPIC = "topic";
+ private static final String CUSTOM_VALUE = "1048576";
+
+ /**
+ * synonyms of `segment.bytes`
+ */
+ private static final String LOG_SEGMENT_BYTES = "log.segment.bytes";
+
+ @ClusterTest(types = {Type.KRAFT},
+ serverProperties = {
+ @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
+ @ClusterConfigProperty(id = 3000, key = LOG_SEGMENT_BYTES, value =
CUSTOM_VALUE)
+ })
+ public void
testTopicConfigsGetImpactedIfStaticConfigsAddToController(ClusterInstance
cluster)
+ throws ExecutionException, InterruptedException {
+ try (
+ Admin admin = cluster.admin();
+ Admin adminUsingBootstrapController = cluster.admin(Map.of(), true)
+ ) {
+ String value = admin.createTopics(List.of(new NewTopic(TOPIC, 1,
(short) 1)))
+
.config(TOPIC).get().get(TopicConfig.SEGMENT_BYTES_CONFIG).value();
+ assertEquals(CUSTOM_VALUE, value, "Config value should be custom
value since controller have related static config");
+
+ ConfigResource brokerResource = new
ConfigResource(ConfigResource.Type.BROKER, "0");
+ String valueFromBroker =
admin.describeConfigs(List.of(brokerResource))
+
.all().get().get(brokerResource).get(LOG_SEGMENT_BYTES).value();
+ assertNotEquals(CUSTOM_VALUE,
+ valueFromBroker,
+ "Config value should not be custom value since broker don't
have related static config");
+
+ ConfigResource controllerResource = new
ConfigResource(ConfigResource.Type.BROKER, "3000");
+ String valueFromController =
adminUsingBootstrapController.describeConfigs(List.of(controllerResource))
+
.all().get().get(controllerResource).get(LOG_SEGMENT_BYTES).value();
+ assertEquals(CUSTOM_VALUE,
+ valueFromController,
+ "Config value should be custom value since controller have
related static config");
+ }
+ }
+
+ @ClusterTest(types = {Type.KRAFT},
+ serverProperties = {
+ @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
+ @ClusterConfigProperty(id = 0, key = LOG_SEGMENT_BYTES, value =
CUSTOM_VALUE)
+ })
+ public void
testTopicConfigsGetImpactedIfStaticConfigsAddToBroker(ClusterInstance cluster)
+ throws ExecutionException, InterruptedException {
+ try (
+ Admin admin = cluster.admin();
+ Admin adminUsingBootstrapController = cluster.admin(Map.of(), true)
+ ) {
+ String value = admin.createTopics(List.of(new NewTopic(TOPIC, 1,
(short) 1)))
+
.config(TOPIC).get().get(TopicConfig.SEGMENT_BYTES_CONFIG).value();
+ assertNotEquals(CUSTOM_VALUE,
+ value,
+ "Config value should not be custom value since controller
don't have static config");
+
+ ConfigResource brokerResource = new
ConfigResource(ConfigResource.Type.BROKER, "0");
+ String valueFromBroker =
admin.describeConfigs(List.of(brokerResource))
+
.all().get().get(brokerResource).get(LOG_SEGMENT_BYTES).value();
+ assertEquals(CUSTOM_VALUE,
+ valueFromBroker,
+ "Config value should be custom value since broker have related
static config");
+
+ ConfigResource controllerResource = new
ConfigResource(ConfigResource.Type.BROKER, "3000");
+ String valueFromController =
adminUsingBootstrapController.describeConfigs(List.of(controllerResource))
+
.all().get().get(controllerResource).get(LOG_SEGMENT_BYTES).value();
+ assertNotEquals(CUSTOM_VALUE,
+ valueFromController,
+ "Config value should not be custom value since controller
don't have related static config");
Review Comment:
`don't` -> `doesn't`
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/StaticBrokerConfigTest.java:
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.admin;
+
+
+import org.apache.kafka.common.config.ConfigResource;
+import org.apache.kafka.common.config.TopicConfig;
+import org.apache.kafka.common.test.ClusterInstance;
+import org.apache.kafka.common.test.api.ClusterConfigProperty;
+import org.apache.kafka.common.test.api.ClusterTest;
+import org.apache.kafka.common.test.api.Type;
+import org.apache.kafka.common.test.junit.ClusterTestExtensions;
+import org.apache.kafka.coordinator.group.GroupCoordinatorConfig;
+
+import org.junit.jupiter.api.extension.ExtendWith;
+
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ExecutionException;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+
+@ExtendWith(value = ClusterTestExtensions.class)
+public class StaticBrokerConfigTest {
+ private static final String TOPIC = "topic";
+ private static final String CUSTOM_VALUE = "1048576";
+
+ /**
+ * synonyms of `segment.bytes`
+ */
+ private static final String LOG_SEGMENT_BYTES = "log.segment.bytes";
+
+ @ClusterTest(types = {Type.KRAFT},
+ serverProperties = {
+ @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
+ @ClusterConfigProperty(id = 3000, key = LOG_SEGMENT_BYTES, value =
CUSTOM_VALUE)
+ })
+ public void
testTopicConfigsGetImpactedIfStaticConfigsAddToController(ClusterInstance
cluster)
+ throws ExecutionException, InterruptedException {
+ try (
+ Admin admin = cluster.admin();
+ Admin adminUsingBootstrapController = cluster.admin(Map.of(), true)
+ ) {
+ String value = admin.createTopics(List.of(new NewTopic(TOPIC, 1,
(short) 1)))
+
.config(TOPIC).get().get(TopicConfig.SEGMENT_BYTES_CONFIG).value();
+ assertEquals(CUSTOM_VALUE, value, "Config value should be custom
value since controller have related static config");
+
+ ConfigResource brokerResource = new
ConfigResource(ConfigResource.Type.BROKER, "0");
+ String valueFromBroker =
admin.describeConfigs(List.of(brokerResource))
+
.all().get().get(brokerResource).get(LOG_SEGMENT_BYTES).value();
+ assertNotEquals(CUSTOM_VALUE,
+ valueFromBroker,
+ "Config value should not be custom value since broker don't
have related static config");
+
+ ConfigResource controllerResource = new
ConfigResource(ConfigResource.Type.BROKER, "3000");
+ String valueFromController =
adminUsingBootstrapController.describeConfigs(List.of(controllerResource))
+
.all().get().get(controllerResource).get(LOG_SEGMENT_BYTES).value();
+ assertEquals(CUSTOM_VALUE,
+ valueFromController,
+ "Config value should be custom value since controller have
related static config");
+ }
+ }
+
+ @ClusterTest(types = {Type.KRAFT},
+ serverProperties = {
+ @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
+ @ClusterConfigProperty(id = 0, key = LOG_SEGMENT_BYTES, value =
CUSTOM_VALUE)
+ })
+ public void
testTopicConfigsGetImpactedIfStaticConfigsAddToBroker(ClusterInstance cluster)
+ throws ExecutionException, InterruptedException {
+ try (
+ Admin admin = cluster.admin();
+ Admin adminUsingBootstrapController = cluster.admin(Map.of(), true)
+ ) {
+ String value = admin.createTopics(List.of(new NewTopic(TOPIC, 1,
(short) 1)))
+
.config(TOPIC).get().get(TopicConfig.SEGMENT_BYTES_CONFIG).value();
+ assertNotEquals(CUSTOM_VALUE,
+ value,
+ "Config value should not be custom value since controller
don't have static config");
+
+ ConfigResource brokerResource = new
ConfigResource(ConfigResource.Type.BROKER, "0");
+ String valueFromBroker =
admin.describeConfigs(List.of(brokerResource))
+
.all().get().get(brokerResource).get(LOG_SEGMENT_BYTES).value();
+ assertEquals(CUSTOM_VALUE,
+ valueFromBroker,
+ "Config value should be custom value since broker have related
static config");
+
+ ConfigResource controllerResource = new
ConfigResource(ConfigResource.Type.BROKER, "3000");
+ String valueFromController =
adminUsingBootstrapController.describeConfigs(List.of(controllerResource))
+
.all().get().get(controllerResource).get(LOG_SEGMENT_BYTES).value();
+ assertNotEquals(CUSTOM_VALUE,
Review Comment:
Could you please verify the `source()` too?
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/StaticBrokerConfigTest.java:
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.admin;
+
+
+import org.apache.kafka.common.config.ConfigResource;
+import org.apache.kafka.common.config.TopicConfig;
+import org.apache.kafka.common.test.ClusterInstance;
+import org.apache.kafka.common.test.api.ClusterConfigProperty;
+import org.apache.kafka.common.test.api.ClusterTest;
+import org.apache.kafka.common.test.api.Type;
+import org.apache.kafka.common.test.junit.ClusterTestExtensions;
+import org.apache.kafka.coordinator.group.GroupCoordinatorConfig;
+
+import org.junit.jupiter.api.extension.ExtendWith;
+
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ExecutionException;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+
+@ExtendWith(value = ClusterTestExtensions.class)
+public class StaticBrokerConfigTest {
+ private static final String TOPIC = "topic";
+ private static final String CUSTOM_VALUE = "1048576";
+
+ /**
+ * synonyms of `segment.bytes`
+ */
+ private static final String LOG_SEGMENT_BYTES = "log.segment.bytes";
+
+ @ClusterTest(types = {Type.KRAFT},
+ serverProperties = {
+ @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
+ @ClusterConfigProperty(id = 3000, key = LOG_SEGMENT_BYTES, value =
CUSTOM_VALUE)
+ })
+ public void
testTopicConfigsGetImpactedIfStaticConfigsAddToController(ClusterInstance
cluster)
+ throws ExecutionException, InterruptedException {
+ try (
+ Admin admin = cluster.admin();
+ Admin adminUsingBootstrapController = cluster.admin(Map.of(), true)
+ ) {
+ String value = admin.createTopics(List.of(new NewTopic(TOPIC, 1,
(short) 1)))
+
.config(TOPIC).get().get(TopicConfig.SEGMENT_BYTES_CONFIG).value();
+ assertEquals(CUSTOM_VALUE, value, "Config value should be custom
value since controller have related static config");
+
+ ConfigResource brokerResource = new
ConfigResource(ConfigResource.Type.BROKER, "0");
+ String valueFromBroker =
admin.describeConfigs(List.of(brokerResource))
+
.all().get().get(brokerResource).get(LOG_SEGMENT_BYTES).value();
+ assertNotEquals(CUSTOM_VALUE,
+ valueFromBroker,
+ "Config value should not be custom value since broker don't
have related static config");
+
+ ConfigResource controllerResource = new
ConfigResource(ConfigResource.Type.BROKER, "3000");
+ String valueFromController =
adminUsingBootstrapController.describeConfigs(List.of(controllerResource))
+
.all().get().get(controllerResource).get(LOG_SEGMENT_BYTES).value();
+ assertEquals(CUSTOM_VALUE,
+ valueFromController,
+ "Config value should be custom value since controller have
related static config");
+ }
+ }
+
+ @ClusterTest(types = {Type.KRAFT},
+ serverProperties = {
+ @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
+ @ClusterConfigProperty(id = 0, key = LOG_SEGMENT_BYTES, value =
CUSTOM_VALUE)
+ })
+ public void
testTopicConfigsGetImpactedIfStaticConfigsAddToBroker(ClusterInstance cluster)
+ throws ExecutionException, InterruptedException {
+ try (
+ Admin admin = cluster.admin();
+ Admin adminUsingBootstrapController = cluster.admin(Map.of(), true)
+ ) {
+ String value = admin.createTopics(List.of(new NewTopic(TOPIC, 1,
(short) 1)))
+
.config(TOPIC).get().get(TopicConfig.SEGMENT_BYTES_CONFIG).value();
+ assertNotEquals(CUSTOM_VALUE,
+ value,
+ "Config value should not be custom value since controller
don't have static config");
+
+ ConfigResource brokerResource = new
ConfigResource(ConfigResource.Type.BROKER, "0");
+ String valueFromBroker =
admin.describeConfigs(List.of(brokerResource))
+
.all().get().get(brokerResource).get(LOG_SEGMENT_BYTES).value();
+ assertEquals(CUSTOM_VALUE,
Review Comment:
Could you please verify the `source()` too?
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/StaticBrokerConfigTest.java:
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.admin;
+
+
+import org.apache.kafka.common.config.ConfigResource;
+import org.apache.kafka.common.config.TopicConfig;
+import org.apache.kafka.common.test.ClusterInstance;
+import org.apache.kafka.common.test.api.ClusterConfigProperty;
+import org.apache.kafka.common.test.api.ClusterTest;
+import org.apache.kafka.common.test.api.Type;
+import org.apache.kafka.common.test.junit.ClusterTestExtensions;
+import org.apache.kafka.coordinator.group.GroupCoordinatorConfig;
+
+import org.junit.jupiter.api.extension.ExtendWith;
+
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ExecutionException;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+
+@ExtendWith(value = ClusterTestExtensions.class)
+public class StaticBrokerConfigTest {
+ private static final String TOPIC = "topic";
+ private static final String CUSTOM_VALUE = "1048576";
+
+ /**
+ * synonyms of `segment.bytes`
+ */
+ private static final String LOG_SEGMENT_BYTES = "log.segment.bytes";
+
+ @ClusterTest(types = {Type.KRAFT},
+ serverProperties = {
+ @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
+ @ClusterConfigProperty(id = 3000, key = LOG_SEGMENT_BYTES, value =
CUSTOM_VALUE)
+ })
+ public void
testTopicConfigsGetImpactedIfStaticConfigsAddToController(ClusterInstance
cluster)
+ throws ExecutionException, InterruptedException {
+ try (
+ Admin admin = cluster.admin();
+ Admin adminUsingBootstrapController = cluster.admin(Map.of(), true)
+ ) {
+ String value = admin.createTopics(List.of(new NewTopic(TOPIC, 1,
(short) 1)))
+
.config(TOPIC).get().get(TopicConfig.SEGMENT_BYTES_CONFIG).value();
+ assertEquals(CUSTOM_VALUE, value, "Config value should be custom
value since controller have related static config");
+
+ ConfigResource brokerResource = new
ConfigResource(ConfigResource.Type.BROKER, "0");
+ String valueFromBroker =
admin.describeConfigs(List.of(brokerResource))
+
.all().get().get(brokerResource).get(LOG_SEGMENT_BYTES).value();
+ assertNotEquals(CUSTOM_VALUE,
+ valueFromBroker,
+ "Config value should not be custom value since broker don't
have related static config");
+
+ ConfigResource controllerResource = new
ConfigResource(ConfigResource.Type.BROKER, "3000");
+ String valueFromController =
adminUsingBootstrapController.describeConfigs(List.of(controllerResource))
+
.all().get().get(controllerResource).get(LOG_SEGMENT_BYTES).value();
+ assertEquals(CUSTOM_VALUE,
Review Comment:
Could you please verify the `source()` too?
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/StaticBrokerConfigTest.java:
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.admin;
+
+
+import org.apache.kafka.common.config.ConfigResource;
+import org.apache.kafka.common.config.TopicConfig;
+import org.apache.kafka.common.test.ClusterInstance;
+import org.apache.kafka.common.test.api.ClusterConfigProperty;
+import org.apache.kafka.common.test.api.ClusterTest;
+import org.apache.kafka.common.test.api.Type;
+import org.apache.kafka.common.test.junit.ClusterTestExtensions;
+import org.apache.kafka.coordinator.group.GroupCoordinatorConfig;
+
+import org.junit.jupiter.api.extension.ExtendWith;
+
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ExecutionException;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+
+@ExtendWith(value = ClusterTestExtensions.class)
+public class StaticBrokerConfigTest {
+ private static final String TOPIC = "topic";
+ private static final String CUSTOM_VALUE = "1048576";
+
+ /**
+ * synonyms of `segment.bytes`
+ */
+ private static final String LOG_SEGMENT_BYTES = "log.segment.bytes";
+
+ @ClusterTest(types = {Type.KRAFT},
+ serverProperties = {
+ @ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
+ @ClusterConfigProperty(id = 3000, key = LOG_SEGMENT_BYTES, value =
CUSTOM_VALUE)
+ })
+ public void
testTopicConfigsGetImpactedIfStaticConfigsAddToController(ClusterInstance
cluster)
+ throws ExecutionException, InterruptedException {
+ try (
+ Admin admin = cluster.admin();
+ Admin adminUsingBootstrapController = cluster.admin(Map.of(), true)
+ ) {
+ String value = admin.createTopics(List.of(new NewTopic(TOPIC, 1,
(short) 1)))
+
.config(TOPIC).get().get(TopicConfig.SEGMENT_BYTES_CONFIG).value();
+ assertEquals(CUSTOM_VALUE, value, "Config value should be custom
value since controller have related static config");
+
+ ConfigResource brokerResource = new
ConfigResource(ConfigResource.Type.BROKER, "0");
+ String valueFromBroker =
admin.describeConfigs(List.of(brokerResource))
+
.all().get().get(brokerResource).get(LOG_SEGMENT_BYTES).value();
+ assertNotEquals(CUSTOM_VALUE,
Review Comment:
Could you please verify the `source()` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
