kirktrue commented on code in PR #19217: URL: https://github.com/apache/kafka/pull/19217#discussion_r1999895425
########## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/DescribeAuthorizedOperationsTest.java: ########## @@ -154,7 +147,7 @@ public void testConsumerGroupAuthorizedOperations(ClusterInstance clusterInstanc assertEquals(3, describeConsumerGroupsResult.describedGroups().size()); ConsumerGroupDescription group1Description = describeConsumerGroupsResult.describedGroups().get(GROUP1).get(); - assertEquals(AclEntry.supportedOperations(ResourceType.GROUP), group1Description.authorizedOperations()); + Assertions.assertEquals(AclEntry.supportedOperations(ResourceType.GROUP), group1Description.authorizedOperations()); Review Comment: Can we use a static import for `Assertions.assertEquals()`? ########## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ClientTelemetryTest.java: ########## @@ -159,7 +158,7 @@ private static String[] toArray(List<String>... lists) { /** * We should add a ClientTelemetry into plugins to test the clientInstanceId method Otherwise the - * {@link org.apache.kafka.common.protocol.ApiKeys.GET_TELEMETRY_SUBSCRIPTIONS } command will not be supported + * {@link org.apache.kafka.common.protocol.ApiKeys#GET_TELEMETRY_SUBSCRIPTIONS } command will not be supported Review Comment: Since the line is being updated, can we remove the superfluous spaces? ```suggestion * {@link org.apache.kafka.common.protocol.ApiKeys#GET_TELEMETRY_SUBSCRIPTIONS} command will not be supported ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org