[
https://issues.apache.org/jira/browse/KAFKA-18054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936450#comment-17936450
]
Bruno Cadonna commented on KAFKA-18054:
---------------------------------------
[~lorcanj] Thank you for you interest in Kafka Streams!
Your investigation seems to be correct. Basically, you are saying that in some
situations there isn't anything that we can compare. If yes, part of this fix
should be to make sure there is always something we can compare by storing the
configs within the object.
For context, it might make sense for you to also follow the discussions on
[KIP-1138: Clean up {{TopologyConfig}} and API for supplying configs needed by
the topology](https://cwiki.apache.org/confluence/x/Y49EF). Feel free to also
join the discussion.
{{TopologyConfig}} will most probably be deprecated. So, we should discuss if
it is worth to fix something that will be deprecated. But even if
{{TopologyConfig}} will be deprecated we will have a similar issue, when
passing {{StreamsConfig}} to the {{Topology}} and to {{KafkaStreams}}.
> Automatically detect missed configs needed by a topology
> --------------------------------------------------------
>
> Key: KAFKA-18054
> URL: https://issues.apache.org/jira/browse/KAFKA-18054
> Project: Kafka
> Issue Type: Sub-task
> Components: streams
> Reporter: A. Sophie Blee-Goldman
> Assignee: Lorcan
> Priority: Major
>
> See umbrella ticket for problem summary.
> This ticket would help tackle the first issue and would be a signifciant
> improvement without requiring a KIP.
> Basically, we should help users avoid accidentally misconfiguring their
> application by setting one of the topology-specific configs in their
> StreamsConfig but only passing it into the KafkaStreams constructor and not
> into the topology where it actually is applied.
> We should be able to detect this case pretty easily: when the topology and
> application configs are passed into the KafkaStreams constructor, we just
> compare the topology's configs with the provided application configs and look
> for each of the topology-specific configs (see umbrella ticket for the list).
> If any of these configs were set by the user in the application configs but
> not set in the topology's configs, we can throw an exception.
> We should also log a warning if the config is set in both cases but have a
> different value.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
