mimaison commented on code in PR #19064:
URL: https://github.com/apache/kafka/pull/19064#discussion_r2004270758
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1723,7 +1723,7 @@ class ReplicaManager(val config: KafkaConfig,
metadata => findPreferredReadReplica(partition, metadata,
params.replicaId, fetchInfo.fetchOffset, fetchTimeMs))
if (preferredReadReplica.isDefined) {
- replicaSelectorOpt.foreach { selector =>
+ replicaSelectorPlugin.foreach { selector =>
debug(s"Replica selector ${selector.getClass.getSimpleName}
returned preferred replica " +
Review Comment:
Isn't it going to print `Replica selector Plugin returned preferred replica`
now?
Instead we want `Replica selector RackAwareReplicaSelector returned
preferred replica` so I think we need to call
`${selector.get.getClass.getSimpleName}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
