FrankYang0529 commented on code in PR #19174: URL: https://github.com/apache/kafka/pull/19174#discussion_r2004985073
########## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ########## @@ -605,6 +616,9 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaConfig) extends Logging } } +/** + * Implement [[org.apache.kafka.server.config.BrokerReconfigurable]] instead. + */ trait BrokerReconfigurable { Review Comment: @frankvicky Do you want to include replacing `kafka.server.BrokerReconfigurable` with `org.apache.kafka.server.config.BrokerReconfigurable` in this PR? Or you prefer to do it in next PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org