chia7712 commented on code in PR #18850:
URL: https://github.com/apache/kafka/pull/18850#discussion_r2005768562
##########
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##########
@@ -110,7 +110,7 @@ public class AbstractConfig {
@SuppressWarnings({"this-escape"})
public AbstractConfig(ConfigDef definition, Map<?, ?> originals,
Map<String, ?> configProviderProps, boolean doLog) {
Map<String, Object> originalMap =
Utils.castToStringObjectMap(originals);
Review Comment:
Sorry for late review, but it seems the return value of
`preProcessParsedConfig` is not used. We need a minor patch. for example:
```java
Map<String, Object> originalMap =
preProcessParsedConfig(Utils.castToStringObjectMap(originals));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
