FrankYang0529 commented on code in PR #19240:
URL: https://github.com/apache/kafka/pull/19240#discussion_r2005767333
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -474,24 +475,28 @@ public void testUncleanShutdownBrokerElrEnabled() throws
Throwable {
setClusterId(active.clusterId()).
setFeatures(features).
setIncarnationId(Uuid.randomUuid()).
- setLogDirs(List.of(Uuid.randomUuid())).
+
setLogDirs(List.of(brokerLogDirs.get(brokerToUncleanShutdown))).
setListeners(listeners));
brokerEpochs.put(brokerToUncleanShutdown, reply.get().epoch());
partition = active.replicationControl().getPartition(topicIdFoo,
0);
assertArrayEquals(new int[]{brokerToBeTheLeader}, partition.elr,
partition.toString());
assertArrayEquals(lastKnownElr, partition.lastKnownElr,
partition.toString());
// Unclean shutdown should not remove the last known ELR members.
- active.registerBroker(
+ CompletableFuture<BrokerRegistrationReply> replyLeader =
active.registerBroker(
anonymousContextFor(ApiKeys.BROKER_REGISTRATION),
new BrokerRegistrationRequestData().
setBrokerId(brokerToBeTheLeader).
setClusterId(active.clusterId()).
setFeatures(features).
setIncarnationId(Uuid.randomUuid()).
setPreviousBrokerEpoch(brokerEpochs.get(brokerToBeTheLeader)).
- setLogDirs(List.of(Uuid.randomUuid())).
+
setLogDirs(List.of(brokerLogDirs.get(brokerToBeTheLeader))).
setListeners(listeners));
+ brokerEpochs.put(brokerToBeTheLeader, replyLeader.get().epoch());
+ partition = active.replicationControl().getPartition(topicIdFoo,
0);
+ assertArrayEquals(new int[]{brokerToBeTheLeader}, partition.elr,
partition.toString());
Review Comment:
Add more content for it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
