jolshan commented on code in PR #19210:
URL: https://github.com/apache/kafka/pull/19210#discussion_r2006162921


##########
metadata/src/main/java/org/apache/kafka/metadata/storage/Formatter.java:
##########
@@ -348,15 +348,22 @@ private short effectiveKRaftFeatureLevel(Optional<Short> 
configuredKRaftVersionL
         if (configuredKRaftVersionLevel.isPresent()) {
             if (configuredKRaftVersionLevel.get() == 0) {
                 if (hasDynamicQuorum()) {
-                    throw new FormatterException("Cannot set kraft.version to 
" +
-                        configuredKRaftVersionLevel.get() + " if KIP-853 
configuration is present. " +
-                            "Try removing the --feature flag for 
kraft.version.");
+                    throw new FormatterException(

Review Comment:
   Thanks for the PR. I guess this error only occurs for Kraft.version 0 and 
the dynamic controller flags are set. Would it be useful to say, "if you would 
like a dynamic quorum, try removing the ..."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to