kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r2006103261
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -3637,6 +3637,11 @@ QuorumState quorum() {
return quorum;
}
+ // Visible only for test
+ KRaftControlRecordStateMachine partitionState() {
Review Comment:
I think I understand what you're suggesting. Basically, we store the
information we care about from the `partitionState` in `MockLog`, and update
them accordingly when we append records or advance the HWM.
For my understanding, why is it a concern that the test is using this? I see
that `RaftEventSimulationTest` is already using several `KafkaRaftClient`
specific methods that aren't defined in the `RaftClient` interface (i.e.
`quorum()`, `poll()`, etc.).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
