[ 
https://issues.apache.org/jira/browse/KAFKA-19027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937395#comment-17937395
 ] 

Chia-Ping Tsai commented on KAFKA-19027:
----------------------------------------

Some tests may need some specific configs to be speedup/stabilized. for example

{code:java}
        serverProperties.put(GROUP_INITIAL_REBALANCE_DELAY_MS_CONFIG, "1000");
        serverProperties.put(CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG, 
"500");
        serverProperties.put(CONSUMER_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG, 
"500");
{code}
 

> Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-19027
>                 URL: https://issues.apache.org/jira/browse/KAFKA-19027
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Major
>
> KAFKA-18329 will remove old coordinator, so 
> `ConsumerGroupCommandTestUtils#generator` creates only one config now. Hence, 
> we should use ClusterTestDefaults to write more readable code for tests. for 
> example
> {code:java}
> @ClusterTestDefaults(
>     types = {Type.CO_KRAFT},
>     serverProperties = {
>         @ClusterConfigProperty(key = OFFSETS_TOPIC_PARTITIONS_CONFIG, value = 
> "1"),
>         @ClusterConfigProperty(key = OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, 
> value = "1"),
>     }
> )
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to