m1a2st commented on code in PR #18930:
URL: https://github.com/apache/kafka/pull/18930#discussion_r2014432276
##########
clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java:
##########
@@ -289,6 +295,13 @@ protected Map<String, Object>
postProcessParsedConfig(final Map<String, Object>
CommonClientConfigs.warnDisablingExponentialBackoff(this);
return CommonClientConfigs.postProcessReconnectBackoffConfigs(this,
parsedValues);
}
+
+ @Override
+ public Map<String, Object> originals() {
Review Comment:
When I traced `WorkerConfig`, I found that it was removed in the
`originals()` method. This method is used to create admins like `TopicAdmin` or
within `adminFactory`. Therefore, I think that when creating an `Admin`, we
cannot pass this configuration.
https://github.com/apache/kafka/blob/56d1dc1b6e12a8a325c91749485aa03bce17c7f1/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java#L458
https://github.com/apache/kafka/blob/56d1dc1b6e12a8a325c91749485aa03bce17c7f1/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java#L943
https://github.com/apache/kafka/blob/56d1dc1b6e12a8a325c91749485aa03bce17c7f1/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java#L2146
If I missed or misunderstood anything, please let me know. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
