chia7712 commented on code in PR #17982:
URL: https://github.com/apache/kafka/pull/17982#discussion_r2007782255
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -5252,7 +5066,7 @@ private CoordinatorResult<Void, CoordinatorRecord>
tryCompleteInitialRebalanceEl
if (group.newMemberAdded() && remainingMs != 0) {
// A new member was added. Extend the delay.
group.setNewMemberAdded(false);
- int newDelayMs = Math.min(classicGroupInitialRebalanceDelayMs,
remainingMs);
+ int newDelayMs =
Math.min(config.classicGroupInitialRebalanceDelayMs(), remainingMs);
int newRemainingMs = Math.max(remainingMs - delayMs, 0);
Review Comment:
@dajac Given that `newDelayMs` is the value utilized by the scheduler,
should we modify the expression to `Math.max(remainingMs - newDelayMs, 0)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
