TaiJuWu commented on PR #19300: URL: https://github.com/apache/kafka/pull/19300#issuecomment-2760216868
> @TaiJuWu Thanks for the patch. Out of curiosity, have we checked that jmx metric names are not altered by this change? I think that they are generated based on the order in the data structure. Hi @dajac , thanks for your review. I thinks the order is not changed. Both of them are following. <img width="651" alt="Screenshot 2025-03-28 at 13 02 25" src="https://github.com/user-attachments/assets/2a5e45e5-2036-4e82-a29d-228fcf9432a4"; /> But I am a little confused why we need to care `jmx metrics name`? In the past, we use `HashMap` so it is unordered but we use `LinkedHashMap` in this PR. The former is non-deterministic and dependent on different implementation but the latter is deterministic. If there is any user assume metrics order are deterministic, that is an issue they need to fix. If I misunderstood anything, please correct me, thanks. Another thing was here is a PR related `MetricName` https://github.com/apache/kafka/pull/19222, it is difficult if we want to check all order is same as before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
